[FFmpeg-devel] [PATCH]Fix dxva2 detection

Ramiro Polla ramiro.polla at gmail.com
Tue Sep 13 02:20:08 CEST 2011


Hi Carl,

On Mon, Sep 12, 2011 at 6:56 PM, Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:
> I needed this patch on Win64, any objections?
> See libavcodec/dxva2_internal.h, line 26.
>
> Please comment, Carl Eugen

The only issue I know of while detecting dxva2 with mingw-w64 is
caused by this line:
check_struct dxva2api.h DXVA_PictureParameters wDecodedPictureIndex

This is related to dxva2api.h provided by videolan. This struct was
added at some point at the same time vc1 dxva2 was added to FFmpeg. To
prevent builds failing when people used the old version of dxva2api.h,
this check was added to configure in r21444.

I don't think anyone still has that old version of dxva2api.h from
videolan. mingw-w64 should be used instead of mingw32, and mingw-w64
contains a proper dxva2api.h, which is properly detected by configure
as-is. The only issue is that vc1 dxva2 is not enabled in mingw-w64
because that check lacks -D_WIN32_WINNT=0x0600. I suggest that check
be removed (r21444 be reverted).

Ramiro


More information about the ffmpeg-devel mailing list