[FFmpeg-devel] [PATCH] asrc_anullsrc: extend syntax to make it accept a non positional list of argument

[Stefano Sabatini]

On date Sunday 2011-09-18 03:18:21 +0200, Michael Niedermayer encoded:
> On Sun, Sep 18, 2011 at 03:04:53AM +0200, Stefano Sabatini wrote:
> > On date Sunday 2011-09-18 02:06:22 +0200, Michael Niedermayer encoded:
> > > On Sat, Sep 17, 2011 at 12:54:35PM +0200, Stefano Sabatini wrote:
> > > > From: Stefano Sabatini <stefasab at gmail.com>
> > > > 
> > > > The new syntax is more extensible and more user-friendly.
> > > > 
> > > > This breaks the previous syntax, should not be an issue as possibly
> > > > no-one is already using the anullsrc.
> > > > ---
> > > >  doc/filters.texi            |   26 ++++++++++++------
> > > >  libavfilter/asrc_anullsrc.c |   62 +++++++++++++++++++++++++++++-------------
> > > >  2 files changed, 60 insertions(+), 28 deletions(-)
> > > 
> > > i liked the old syntax but if you prefer this new syntax then fine
> > > with me
> > 
> > My point is that I dislike the syntax:
> > 12:34:56
> 
> thats a time :)
> 48000:mono
> is the sample rate + the channel layout
> 
> 
> > 
> > since it doesn't give a clue about what the parameters mean (and you
> > need to check the docs, if unlucky the source). Also this becomes even
> > worse when you have optional parameters which don't need to be
> > explicitely set (with positional arguments you're forced to set them),
> > if you need to add more parameters (as in this case) it becomes more
> > and more clumsy and error prone.
> > 
> > That's why I favor named parameters over positional ones.
> 
> i absolutely see your point but this filter has just 2 parameters
> and one is real big and one is real small.
> even if one specifies them the wrong way around the filter could detect
> this, (consider 6 samples per second with 8000 channels)

Yes, but consider if I add more parameters (timebase, duration,
packing format).

> anyway, as said i dont mind the change and patch if you prefer it this
> way

Pushed.
-- 
FFmpeg = Fabulous and Fiendish Magnificient Pacific Extended Gnome