[FFmpeg-devel] [PATCH]Parse ac3 in mov

[Reimar Döffinger]

On Wed, Sep 21, 2011 at 01:22:46PM +0200, Carl Eugen Hoyos wrote:
> Hi!
> 
> Attached patch fixes ticket #494.
> 
> Please comment, Carl Eugen

> diff --git a/libavformat/mov.c b/libavformat/mov.c
> index 70cd776..6ed06ff 100644
> --- a/libavformat/mov.c
> +++ b/libavformat/mov.c
> @@ -1272,6 +1272,8 @@ int ff_mov_read_stsd_entries(MOVContext *c, AVIOContext *pb, int entries)
>              st->codec->sample_rate = AV_RB32(st->codec->extradata+32);
>          }
>          break;
> +    case CODEC_ID_AC3:
> +            st->need_parsing = AVSTREAM_PARSE_FULL;

Indentation is off.
I also don't know whether it is valid to pack AC3 into mov in such a
way.
Might still be reasonable to do this even if not though, no real
opinion.