[FFmpeg-devel] [PATCH] vf_drawtext: make x and y options parametric

[Stefano Sabatini]

On date Friday 2011-09-23 14:48:48 +0200, Stefano Sabatini encoded:
> On date Wednesday 2011-09-21 16:51:11 +0200, Michael Niedermayer encoded:
> > On Wed, Sep 21, 2011 at 02:51:16PM +0200, Stefano Sabatini wrote:
> > > On date Tuesday 2011-09-20 21:44:46 +0200, Michael Niedermayer encoded:
> > > > On Tue, Sep 20, 2011 at 08:30:46PM +0200, Stefano Sabatini wrote:
> > > > > Address trac issue #378.
> > > > > ---
> > > > >  doc/filters.texi          |   68 ++++++++++++++++++++-
> > > > >  libavfilter/vf_drawtext.c |  143 ++++++++++++++++++++++++++++++++++++++++-----
> > > > >  2 files changed, 191 insertions(+), 20 deletions(-)
> > > > 
> > > > ok, but please check that changing them through stdin in ffmpeg still
> > > > works
> > > 
> > > Can you suggest a way to test it? That's all but obvious (and should
> > > be documented in case this is meant to be non only an "experimental"
> > > feature).
> > 
> > try something like:
> > 
> > echo -e 'Call 2 reinit fontfile=/usr/share/fonts/truetype/freefont/FreeSerif.ttf:text=W old:fontcolor=white\nCall 5 reinit fontfile=/usr/share/fonts/truetype/freefont/FreeSerif.ttf:text="Hallo Woldäüö߀":fontcolor=white'
> > (i copy and pasted above from log so it should work)
> 
> pipe reading code doesn't work here with or without the patch, so
> cannot test.

Anyway the only problem I can forecast is the setting of "n" to 0,
attached patch should avoid it. 
-- 
FFmpeg = Frenzy and Fierce Muttering Puristic Extroverse God
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0007-vf_drawtext-do-not-reset-n-variable-to-0-in-case-the.patch
Type: text/x-diff
Size: 1756 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110923/8712fba8/attachment.bin>