[FFmpeg-devel] [PATCH 0/3] ff_h264_decode_extradata hardening

Alexander Strasser eclipse7 at gmx.net
Sun Sep 25 23:18:06 CEST 2011


Alexander Strasser wrote:
>   after the recent changes to the ff_h264_decode_extradata function,
> I took a moment to look through the function and the code surrounding
> calls to it.
> 
>   This is what I came up with. The first and second patch of the
> series should probably be merged if they would both be accepted.
> The third patch can only be correct if the two before it got in.
> 
>   I am awaiting your comments!
> 
> Alexander Strasser (3):
>   h264: ff_h264_decode_extradata: check buffer size
>   h264: ff_h264_decode_extradata: check that buf is not NULL
>   h264: improve checks before calling ff_h264_decode_extradata
> 
>  libavcodec/h264.c |    8 +++++---
>  1 files changed, 5 insertions(+), 3 deletions(-)

  Sorry I forgot to say: all pushed.

  I squashed the 2nd patch into the first and fixed the indentation.

  Alexander


More information about the ffmpeg-devel mailing list