[FFmpeg-devel] [PATCH 1/4] mxfdec: Index table based seeking

[Tomas Härdin]

On Fri, 2011-09-02 at 15:50 +0200, Georg Lippitsch wrote:
> Am 02.09.2011, 09:56 Uhr, schrieb Tomas Härdin <tomas.hardin at codemill.se>:
> 
> > Any news on this?
> 
> Sorry, not really for now.
> I've done a lot of testing with P2 DVCPro files, they seem to work stable.  
> What's most important for me now is merging with your parsing code, so  
> that XDCAM works at reasonable speed. But unfortunately I'm quite busy  
> now, so probably I can do that in around three weeks at earliest ...
> 
> 
> Georg

I took the liberty of refactoring and fixing a few bugs in your patch,
in addition to rebasing my partition parsing code on top of it and
adding some patches to support the V210 sample at
http://titan.codemill.se/~tomhar/samples/multiindex/

The attached patch, 0001-mxfdec-Index-table-based-seeking.patch, is the
*.patch-part* files squashed into one. I included them to make it clear
what I changed, and to not clutter up the history making bisecting more
difficult (assuming the squashed patch is preferred).

Unfortunately fate-seek-lavf_mxf doesn't pass, neither with your
original patch nor the updated one. However, considering the old code
didn't do proper seeking I suspect the test isn't actually correct.

Finally, a few questions about the original patch:
What's the deal with n_delta and i in the original patch? Shouldn't at
least track_id be used instead of i?
The "if (i < mxf->system_item + st->index) n_delta++;" logic also looks
strange - is its purpose to offset past the system item if present?

/Tomas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-mxfdec-Index-table-based-seeking.patch
Type: text/x-patch
Size: 22481 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110927/895c5ecf/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-mxfdec-Index-table-based-seeking.patch-part1
Type: application/mbox
Size: 20612 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110927/895c5ecf/attachment.mbox>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-mxfdec-Refactor-Georg-s-code.patch-part2
Type: application/mbox
Size: 16171 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110927/895c5ecf/attachment-0001.mbox>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-mxfdec-Make-sure-current_sample_index-nb_index_entri.patch-part3
Type: application/mbox
Size: 1188 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110927/895c5ecf/attachment-0002.mbox>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-mxfdec-Sort-index-table-segments-by-BodySID-IndexSID.patch-part4
Type: application/mbox
Size: 6259 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110927/895c5ecf/attachment-0003.mbox>