[FFmpeg-devel] [PATCH] DVBSUBTILES, fixes to decoding/encoding and a new way of burning the subtitles onto the screen

[JULIAN GARDNER]

----- Original Message -----
> From: Michael Niedermayer <michaelni at gmx.at>
> To: FFmpeg development discussions and patches <ffmpeg-devel at ffmpeg.org>
> Cc: 
> Sent: Tuesday, 27 September 2011, 5:12
> Subject: Re: [FFmpeg-devel] [PATCH] DVBSUBTILES, fixes to decoding/encoding and a new way of burning the subtitles onto the screen
> 
> On Mon, Sep 26, 2011 at 11:43:10PM +0100, JULIAN GARDNER wrote:
> [...]
> 
>>  Changes made to dvbsub*.c are to fix to the encoding and decoding, not real 
> much to say but if you use the old source against the TS file i posted to the 
> bug system months ago you will see that it did not work, it does now.
> 
> i tried with ticket/153/bbc_small.ts
> playing it with ffplay works, but not pretty, the colors are off but
> it works. applyimg your patch makes it worse, there are artifacts
> at the right and left of the first "help" text and valgrind reports
> below
> 
> ==31934== Use of uninitialised value of size 8
> ==31934==    at 0x43B0EB: video_image_display (ffplay.c:533)
> ==31934==    by 0x43F71D: main (ffplay.c:968)
> ==31934==
> ==31934== Use of uninitialised value of size 8
> ==31934==    at 0x43B136: video_image_display (ffplay.c:539)
> ==31934==    by 0x43F71D: main (ffplay.c:968)
> ==31934==
> ==31934== Use of uninitialised value of size 8
> ==31934==    at 0x43B17E: video_image_display (ffplay.c:547)
> ==31934==    by 0x43F71D: main (ffplay.c:968)
> ==31934==
> ==31934== Use of uninitialised value of size 8
> ==31934==    at 0x43B205: video_image_display (ffplay.c:553)
> ==31934==    by 0x43F71D: main (ffplay.c:968)
> ==31934==
> 

Attached is a new patch against my previous code which fixes the problem above, what is happening is that we have corrupted data and i was not waiting for a correct start of data. Patch also removes some old code and replaces it with calls to av_log_dump.

Hopefully this is usuable, i used 'git diff', if its no good let me know.

joolz
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dvbsubdec.diff
Type: text/x-patch
Size: 6561 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110927/b3debb57/attachment.bin>