[FFmpeg-devel] [PATCH] Add AVIO_FLAG_DIRECT.

Michael Niedermayer michaelni at gmx.at
Sun Apr 1 20:22:11 CEST 2012


On Sun, Apr 01, 2012 at 08:09:13PM +0200, Reimar Döffinger wrote:
> On Sun, Apr 01, 2012 at 12:11:29PM +0200, Michael Niedermayer wrote:
> > On Wed, Mar 28, 2012 at 10:26:35PM +0200, Reimar Döffinger wrote:
> > > Allows avoiding the buffer when using avio read and write functions.
> > > The test does not work: It works for testing reading, but for
> > > writing avio_flags never gets set in the ffmpeg.c part of the change.
> > 
> > what works, LGTM
> 
> I can't parse that answer.
> Should I commit even though setting the flag for writing and thus
> testing doesn't work?

what i meant was that the code that works (reading) LGTM
i made no comment on the writing code, i dont know why it doesnt work/
havt reviewed it

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

When you are offended at any man's fault, turn to yourself and study your
own failings. Then you will forget your anger. -- Epictetus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120401/11b87d8f/attachment.asc>


More information about the ffmpeg-devel mailing list