[FFmpeg-devel] [PATCH 3/3] parseutils: add av_parse_time() test.

[Michael Niedermayer]

On Tue, Apr 17, 2012 at 12:41:04PM +0200, Nicolas George wrote:
> 
> Signed-off-by: Nicolas George <nicolas.george at normalesup.org>
> ---
>  libavutil/parseutils.c    |   51 ++++++++++++++++++++++++++++++++++++++++++++-
>  tests/ref/fate/parseutils |   12 ++++++++++
>  2 files changed, 62 insertions(+), 1 deletions(-)
> 
> 
> Compared to the approved version, use the same #ifdef trick on time()
> to test dates that depend on the current time.

LGTM

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120417/22c38333/attachment.asc>