[FFmpeg-devel] [PATCH] web: Copy FFmpeg Logo by Makefile instead of cronjob

[Michael Niedermayer]

On Sun, Apr 22, 2012 at 10:44:14PM +0200, Thilo Borgmann wrote:
> Am 22.04.12 19:46, schrieb Reimar Döffinger:
> > On Sun, Apr 22, 2012 at 07:36:30PM +0200, Michael Niedermayer wrote:
> >> On Sat, Apr 21, 2012 at 08:22:40PM +0200, Thilo Borgmann wrote:
> >>> Am 19.04.12 19:18, schrieb Michael Niedermayer:
> >>>>>  Makefile |   14 ++++++++++++--
> >>>>>  1 file changed, 12 insertions(+), 2 deletions(-)
> >>>>> 47b04de93a2e972467f8f6b6a55e63ac3f570b88  0001-web-Let-the-Makefile-copy-the-website-logo-according.patch
> >>>>> From 57ab223b421e83f75761bd7d77098bbf5fd5ea84 Mon Sep 17 00:00:00 2001
> >>>>> From: Thilo Borgmann <thilo.borgmann at googlemail.com>
> >>>>> Date: Tue, 17 Apr 2012 11:37:53 +0200
> >>>>> Subject: [PATCH] web: Let the Makefile copy the website logo according to src/logik.
> >>>>
> >>>> has the makefile been tested with all combinations of copy cases ?
> >>>
> >>> Just retestet. Works well for me for none/$(DATE)-standard/$(DATE).png files
> >>> with and without existing htdocs/ffmpeg-logo.png.
> >>
> >> have the consequences of this being run by a cron job and hook at the
> >> same time been considered ? that is race conditions ?
> > 
> > The worst that should be possible to happen (assuming we keep the cron
> > job from running too close to midnight) is that there are two cps
> > running with same source and destination.
> > I don't know for sure but I'd expect that should not cause an issue.
> > (a bigger issue might be the web server reading the file while it's
> > still being copied, but I don't really think this is relevant either).
> 
> Well the idea was not to keep the cron job, wasn't it?
> 
> Otherwise I don't know if a lock file might help or even increase problematic
> situations.

if theres no cron job how should the logo change ?
the makefile is run when someone does a push, no push, no change.
if the makefile is run by a cronjob and the push hook then not only
does the whole website build run in parallel but a git push can
actually change the source files while the cronjob is runnung make
I had not realized this when the makefile discussions began ...
But this doesnt look safe to me. Also note while now we could limit the
cronjob to just mess with the logo, if we want some text to change
the website really needs a rebuild from the cronjob.

Also i think creating logos and organizing a contest to make them
is what is important. We have a working cronjob (thats disabled now but
can trivially be enabled again) that can switch the logos on a day by
day basis.

If someone wants to write a makefile thats safe to be run in parallel
and has more features than the simply logo copy cronjob thats very
welcome, but i dont volunteer to write & debug such makefile. I
just volunteer to put it on the server after others wrote, reviewed and
tested it.


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I know you won't believe me, but the highest form of Human Excellence is
to question oneself and others. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120425/d5c08061/attachment.asc>