[FFmpeg-devel] [PATCH 1/2] lavfi: merge asrc_abuffer into vsrc_buffer.

[Michael Niedermayer]

On Fri, Apr 27, 2012 at 07:38:34PM +0200, Nicolas George wrote:
> 
> Signed-off-by: Nicolas George <nicolas.george at normalesup.org>
> ---
>  libavfilter/Makefile       |    1 -
>  libavfilter/asrc_abuffer.c |  372 --------------------------------------------
>  libavfilter/vsrc_buffer.c  |  349 ++++++++++++++++++++++++++++++++++++++++--
>  3 files changed, 338 insertions(+), 384 deletions(-)
>  delete mode 100644 libavfilter/asrc_abuffer.c
> 
> 
> This patch contains only the most obvious code sharing.
> It changes slightly the behaviour of abuffer with regard
> errors (EINVAL vs EAGAIN).
> 
> The next step is to unify the various *buffer*_add_* functions.

no objections from me

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Rewriting code that is poorly written but fully understood is good.
Rewriting code that one doesnt understand is a sign that one is less smart
then the original author, trying to rewrite it will not make it better.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120427/2def6053/attachment.asc>