[FFmpeg-devel] [PATCH] 8svx: ensure that packet size is multiple of channels.

Nicolas George nicolas.george at normalesup.org
Wed Aug 1 00:37:33 CEST 2012


Fix an assert failure with packets of invalid size.

Signed-off-by: Nicolas George <nicolas.george at normalesup.org>
---
 libavcodec/8svx.c |    7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)


Avoid underflow.


diff --git a/libavcodec/8svx.c b/libavcodec/8svx.c
index e89b252..37170a8 100644
--- a/libavcodec/8svx.c
+++ b/libavcodec/8svx.c
@@ -112,9 +112,14 @@ static int eightsvx_decode_frame(AVCodecContext *avctx, void *data,
     /* decode and interleave the first packet */
     if (!esc->samples && avpkt) {
         uint8_t *deinterleaved_samples, *p = NULL;
+        int packet_size = avpkt->size;
 
+        if (packet_size % avctx->channels) {
+            av_log(avctx, AV_LOG_WARNING, "Packet with odd size, ignoring last byte\n");
+            packet_size -= packet_size % avctx->channels;
+        }
         esc->samples_size = !esc->table ?
-            avpkt->size : avctx->channels + (avpkt->size-avctx->channels) * 2;
+            packet_size : avctx->channels + (packet_size-avctx->channels) * 2;
         if (!(esc->samples = av_malloc(esc->samples_size)))
             return AVERROR(ENOMEM);
 
-- 
1.7.10.4



More information about the ffmpeg-devel mailing list