[FFmpeg-devel] [PATCH 2/3] lavfi/atempo: remove dead increment.

Clément Bœsch ubitux at gmail.com
Sun Aug 5 23:42:00 CEST 2012


On Sun, Aug 05, 2012 at 11:30:37PM +0200, Nicolas George wrote:
> Le nonidi 19 thermidor, an CCXX, Clément Bœsch a écrit :
> > ---
> >  libavfilter/af_atempo.c | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/libavfilter/af_atempo.c b/libavfilter/af_atempo.c
> > index 959cacb..7971aef 100644
> > --- a/libavfilter/af_atempo.c
> > +++ b/libavfilter/af_atempo.c
> > @@ -553,7 +553,6 @@ static int yae_load_frag(ATempoContext *atempo,
> >  
> >      if (n1) {
> >          memcpy(dst, b + i1 * atempo->stride, n1 * atempo->stride);
> > -        dst += n1 * atempo->stride;
> >      }
> 
> The patch is correct, obviously, but I am not sure the code does not look
> better with it, for the symmetry with the n0/i0 case. If Pavel still lurks
> here, he can give his advice.
> 

I don't mind much; just like with the overlay patch that "issue" was
raises by some experimentations I did with clang static analyzer (after
seeing the csa page provided by qatar). Since atempo is not available in
the fork it was unlikely to get changed so I gave it a thought. But I'll
be able to sleep without this. :)

[...]

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120805/f3066f5a/attachment.asc>


More information about the ffmpeg-devel mailing list