[FFmpeg-devel] [PATCH] lavd/x11grab: deprecate "nomouse" specification in filename

[Stefano Sabatini]

On date Wednesday 2012-08-08 22:51:03 +0200, Clément Bœsch encoded:
> On Wed, Aug 08, 2012 at 11:23:03AM +0200, Stefano Sabatini wrote:
> > Favor draw_mouse option. Should simplify parsing, and make it more
> > robust.
> > ---
> >  libavdevice/x11grab.c |    7 ++++++-
> >  1 files changed, 6 insertions(+), 1 deletions(-)
> > 
> > diff --git a/libavdevice/x11grab.c b/libavdevice/x11grab.c
> > index eb85dd9..80abba9 100644
> > --- a/libavdevice/x11grab.c
> > +++ b/libavdevice/x11grab.c
> > @@ -174,7 +174,12 @@ x11grab_read_header(AVFormatContext *s1)
> >      offset = strchr(dpyname, '+');
> >      if (offset) {
> >          sscanf(offset, "%d,%d", &x_off, &y_off);
> > -        x11grab->draw_mouse = !strstr(offset, "nomouse");
> > +        if (strstr(offset, "nomouse")) {
> > +            av_log(s1, AV_LOG_WARNING,
> > +                   "'nomouse' specification in argument is deprecated: "
> > +                   "use 'draw_mouse' option with value 0 instead\n");
> > +            x11grab->draw_mouse = 0;
> > +        }
> >          *offset= 0;
> >      }
> 
> LGTM

Applied. Thanks for the reviews.
-- 
FFmpeg = Furious & Fostering Multipurpose Picky Embarassing Game