[FFmpeg-devel] [PATCH] build: check for perl presence and compile POD pages only in that case

[Michael Niedermayer]

On Thu, Aug 09, 2012 at 07:59:04PM -0300, jamal wrote:
> On 09/08/12 7:33 PM, jamal wrote:> On 09/08/12 6:39 PM, Stefano Sabatini wrote:
> >> perl is required by the texi2pod.pl script. Should avoid FATE failure on
> >> Haiku, where perl is apparently not available.
> >> ---
> >>  configure    |    5 ++++-
> >>  doc/Makefile |   10 ++++++++--
> >>  2 files changed, 12 insertions(+), 3 deletions(-)
> >>
> >> diff --git a/configure b/configure
> >> index 6c4047f..6dc983f 100755
> >> --- a/configure
> >> +++ b/configure
> >> @@ -1285,6 +1285,7 @@ HAVE_LIST="
> >>      mmap
> >>      nanosleep
> >>      PeekNamedPipe
> >> +    perl
> >>      pod2man
> >>      poll_h
> >>      posix_memalign
> >> @@ -1838,7 +1839,7 @@ ffprobe_deps="avcodec avformat"
> >>  ffserver_deps="avformat ffm_muxer fork rtp_protocol rtsp_demuxer"
> >>  ffserver_extralibs='$ldl'
> >>  
> >> -doc_deps_any="texi2html makeinfo pod2man"
> >> +doc_deps_any="texi2html makeinfo perl pod2man"
> >>  
> >>  # tests
> >>  colormatrix1_test_deps="colormatrix_filter"
> > Maybe make pod2man be dependent on perl using pod2man_deps="perl" instead?
> > That way you can avoid making the changes to doc/Makefiles.
> > 
> > Regards.
> > 
> Now that i think about it, as things are right now pod2man shouldn't even get enabled if perl is not available to begin with.
> If the check "pod2man --help > /dev/null 2>&1 && enable pod2man || disable pod2man" succeeds, then it means perl is available.
> 
> This Haiku system submitting FATE results does have perl, but also a seemingly broken pod2man version, or maybe a very old one.
> There's no need to make any changes IMO. Or at most a pod2man version check if that's why it's failing for this Haiku system.

on that Haiku system:
./texi2pod.pl --help
runtime_loader: Cannot open file /usr/bin/perl: No such file or directory

perl ./texi2pod.pl --help
usage: ./texi2pod.pl [-D toggle...] [infile [outfile]]

perl is at:
/boot/common/bin/perl


[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In a rich man's house there is no place to spit but his face.
-- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120810/a375fbf3/attachment.asc>