[FFmpeg-devel] [PATCH] libavfilter: add vf_hue.c

[Stefano Sabatini]

On date Sunday 2012-08-12 00:46:42 +0200, Nicolas George encoded:
> Le quintidi 25 thermidor, an CCXX, Stefano Sabatini a écrit :
> > This is the name of an already used function (and we should try to
> 
> Yes, of course. I copied the signature of the original function and forgot
> to change the name.
> 
> > The main drawback in this case is that it would make the option order
> > relevant (so you can't sort options by name in the array), unless we
> > provide a secondary list of pointers to options.
> 

> I think keeping the most important options at the beginning of the list
> makes sense anyway, but having the list of short options as argument was my
> second idea for the issue, so if you prefer it that way I do not mind at
> all.

I prefer this for several reasons (relying on options order is
brittle, and won't allow binary searches if we go with it, even if
this is a non-issue since that is not currently possible).
-- 
FFmpeg = Free and Frightening Mind-dumbing Philosofic Experimenting Gospel