[FFmpeg-devel] [PATCH] dvdsubenc: make it usable for transcoding.

[Wolfram Gloger]

Nicolas George <nicolas.george at normalesup.org> writes:

> DVD subtitles packets can only encode a single rectangle:
> if there are several, copy them into a big transparent one.
...
> Signed-off-by: Nicolas George <nicolas.george at normalesup.org>

I dropped reading ffmpeg-devel for the last month.  My fault.

Just a question:  Were you aware of

http://malloc.de/tools/ffmpeg-wg-patches-20110129a.tar.gz

(in particular dvdsubenc.diff) when doing this?  If not, we were nicely
duplicating effort :-(, but arrived at a very similar result :-)...

If you might take a look at my patchset, please look at the latest
version:

http://malloc.de/ffmpeg-patches/dvdsubenc.diff

(applicable to HEAD of about a week ago)
to see if we have arrived at the same feature set.  Your handling
of alpha channel looks better than mine, but the merging of several
subtitle rects into one IMHO is generally useful so I put into a
function av_merge_subtitle().  I was actually afraid that everyone would
scream "this should go into a subtitle filter" and would thus complicate
merging.  Also I think ff_squareTbl should be used for the color
distance.

These are just my first observations, either you or me should check for
further opportunities.

In any case, a "heads up" mail to me would have been nice..

Regards,
Wolfram.