[FFmpeg-devel] [PATCH 1/7] utvideoenc: optimize and simplify mangle_rgb_planes

[Derek Buitenhuis]

On 22/08/2012 10:26 AM, Michael Niedermayer wrote:
> Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> ---
>  libavcodec/utvideoenc.c |   11 +++--------
>  1 file changed, 3 insertions(+), 8 deletions(-)

[...]

This should be aligned with the other two.
                          ↓
> +            unsigned g = src[i + 1] + 0x80;
> +            src[i]     -= g;
> +            src[i + 2] -= g;

I think Jan prefers variables declared at the beginning of the function, but I do not
know if this adversely affects performance.

Looks OK, in general.

- Derek