[FFmpeg-devel] [PATCH]Clarify that there are two different "passlogfile" options

[Stefano Sabatini]

On date Wednesday 2012-08-29 11:33:21 +0200, Carl Eugen Hoyos encoded:
> Hi!
> 
> Attached documentation patch tries to clarify that -passlogfile has a 
> different syntax when used with -vcodec libx264.
> Tries to address ticket #1686.
> 
> Please comment, Carl Eugen

> diff --git a/doc/ffmpeg.texi b/doc/ffmpeg.texi
> index 49d2c0e..18268c7 100644
> --- a/doc/ffmpeg.texi
> +++ b/doc/ffmpeg.texi
> @@ -495,6 +495,10 @@ prefix is ``ffmpeg2pass''. The complete file name will be
>  @file{PREFIX-N.log}, where N is a number specific to the output
>  stream
>  
> +Note that this option is overwritten by a local option of the same name 
> +when using @code{-vcodec libx264}. That option maps to the x264 option stats 
> +which has a different syntax.
> +

In transcode_init():

                snprintf(logfilename, sizeof(logfilename), "%s-%d.log",
                         pass_logfilename_prefix ? pass_logfilename_prefix : DEFAULT_PASS_LOGFILENAME_PREFIX,
                         i);
                if (!strcmp(ost->enc->name, "libx264")) {
                    av_dict_set(&ost->opts, "stats", logfilename, AV_DICT_DONT_OVERWRITE);


So I'd expect the stats file to have the specified name in
logfilename. What am I missing?
-- 
FFmpeg = Fancy Friendly Mean Portable Eccentric Geisha