[FFmpeg-devel] [PATCH 1/2] libavfilter: Support the forks ABI for buffer sinks

Stefano Sabatini stefasab at gmail.com
Fri Aug 31 23:54:22 CEST 2012


On date Friday 2012-08-31 22:38:29 +0200, Michael Niedermayer encoded:
> With this change avconv compiled against libav and linked to ffmpegs libs
> will run through the whole fate testsuite without any crashes.
> 857 tests pass, the remaining tests fail one way or another, which is
> to be expected as avconv is not a drop in replacement for ffmpeg
> The testsuite used was the ffmpeg fate testsuite, not libavs.
> 
> Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> diff --git a/libavfilter/buffersink.c b/libavfilter/buffersink.c
> index e66a099..50cd6d4 100644
> --- a/libavfilter/buffersink.c
> +++ b/libavfilter/buffersink.c
> @@ -141,7 +141,11 @@ int av_buffersink_read_samples(AVFilterContext *ctx, AVFilterBufferRef **pbuf,
>  }
>  
>  AVFilter avfilter_vsink_buffer = {
> +#if AV_HAVE_INCOMPATIBLE_FORK_ABI
> +    .name      = "buffersink",

> +#else
>      .name      = "buffersink_old",
> +#endif

Also while at it, we could give a more meaningful name to this,
e.g. buffersink_libav, or maybe antonsink.

(And yes this belongs to another patch.)
-- 
FFmpeg = Fundamental Funny Martial Plastic Energized Gigant


More information about the ffmpeg-devel mailing list