[FFmpeg-devel] [PATCH] lavc/dvdsubdec: accept palette from options.

[Michael Niedermayer]

On Sat, Dec 01, 2012 at 04:09:59PM +0100, Nicolas George wrote:
> On DVDs, the palette is part of the IFO file and therefore
> not available when reading from a dumped VOB file.
> 
> Signed-off-by: Nicolas George <nicolas.george at normalesup.org>
> ---
>  doc/decoders.texi      |   26 +++++++++++++++++++++++
>  libavcodec/dvdsubdec.c |   55 +++++++++++++++++++++++++++++++++++++++---------
>  2 files changed, 71 insertions(+), 10 deletions(-)
> 
> 
> Same as before, with an example.
> 
> 
> diff --git a/doc/decoders.texi b/doc/decoders.texi
> index 87ad4ee..c5b79b3 100644
> --- a/doc/decoders.texi
> +++ b/doc/decoders.texi
> @@ -61,3 +61,29 @@ use is purely internal and the format of the data it accepts is not publicly
>  documented.
>  
>  @c man end AUDIO DECODERS
> +
> + at chapter Subtitles Decoders
> + at c man begin SUBTILES DECODERS
> +
> + at section dvdsub
> +
> +This codec decodes the bitmap subtitles used in DVDs; the same subtitles can
> +also be found in VobSub file pairs and in some Matroska files.
> +
> + at subsection @Options
> +
> + at table @option
> + at item palette
> +Specify the global palette used by the bitmaps. When stored in VobSub, the
> +palette is normally specified in the index file; in Matroska, the palette is
> +stored in the codec extra-data in the same format as in VobSub. In DVDs, the
> +palette is stored in the IFO file, and therefore not available when reading
> +from dumped VOB files.
> +
> +The format for this option is a string containing 16 24-bits hexadecimal
> +numbers (without 0x prefix) separated by comas, for example @code{0d00ee,
> +ee450d, 101010, eaeaea, 0ce60b, ec14ed, ebff0b, 0d617a, 7b7b7b, d1d1d1,
> +7b2a0e, 0d950c, 0f007b, cf0dec, cfa80c, 7c127b}.
> + at end table

maybe the example should a full command line
otherwise LGTM

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If a bugfix only changes things apparently unrelated to the bug with no
further explanation, that is a good sign that the bugfix is wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20121201/4fd3a709/attachment.asc>