[FFmpeg-devel] [PATCH] lavc/dvdsubdec: accept palette from options.

[Nicolas George]

Le primidi 11 frimaire, an CCXXI, Reimar Döffinger a écrit :
> Usually you would copy the IFO as well.
> I guess making FFmpeg use that IFO might be more difficult
> than just adding this option though.

Probably. Also, inventing a palette by trial-and-error is easy, inventing an
IFO file is hard.

> Why not allowing to set the size as well,

The size can be set by the application accessing the AVCodecContext fields,
not the palette. Right now, ffmpeg does not allow to set the size with an
option, but for PGS this is done with the -s option, just like for video.

>					    i.e. just use the extradata
> text format 1:1?

That would require the option to have several lines, this is rather clumsy.

>		   (which of course leads to the question if we shouldn't
> just have an option to set/replace the extradata).

I do not have any objection to that.

> Also, why refuse to init when the extradata parsing fails but we have
> have all the info?
> Though it seems that right now dvdsub_parse_extradata can't fail anyway.
> I'm not sure that it's a good idea to have a return value if it's not
> used anyway.

dvdsub_parse_extradata() can fail if ENOMEM, this is IMHO not something that
should be ignored.

(Although looking at the code, the malloc is there only to 0-terminate the
extradata, and extradata is already supposed to be 0-padded, so this part
could go away; but this is unrelated.)


About the example: I do not think that a full command line would help, it
would rather confuse things due to the numerous corner cases needed to
encode subtitles.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20121201/0dec6d07/attachment.asc>