[FFmpeg-devel] [PATCH] lswr/swresample: use AV_OPT_TYPE_SAMPLE_FMT for sample format options

[Stefano Sabatini]

On date Saturday 2012-12-01 00:15:37 +0100, Michael Niedermayer encoded:
> On Sat, Dec 01, 2012 at 12:13:18AM +0100, Stefano Sabatini wrote:
> > On date Friday 2012-11-30 04:24:42 +0100, Michael Niedermayer encoded:
> > > On Fri, Nov 30, 2012 at 01:11:14AM +0100, Stefano Sabatini wrote:
> > > > Improve usability and robustness. This is technically an API/ABI break.
> > > 
> > > please elaborate why this is a API/ABI break, so i dont misunderstand
> > > the implications by mistake
> > 
> > With OPT_*_FMT I'm not setting min and max (are set to 0), so
> > opt.c:write_number() fails with an out-of-range.
> > 
> > I could set the range to [-1, FMT_NB-1] and fix it if you think it is
> > a good idea.
> 
> the min and max certainly should be set
> also they should be checked by all ways to set
> 
> consider AV_SAMPLE_FMT_NONE, the min/max is the only way to know if
> its allowed

Updated.
-- 
FFmpeg = Formidable and Faithful Marvellous Proud Elastic Ghost
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-lswr-swresample-use-AV_OPT_TYPE_SAMPLE_FMT-for-sampl.patch
Type: text/x-diff
Size: 5709 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20121201/127d0e62/attachment.bin>