[FFmpeg-devel] [PATCH 2/2] Ensoniq Paris Audio File demuxer

[Paul B Mahol]

On 12/3/12, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Wed, Nov 28, 2012 at 02:09:02AM +0000, Paul B Mahol wrote:
>> Signed-off-by: Paul B Mahol <onemda at gmail.com>
>> ---
>>  doc/general.texi         |   1 +
>>  libavformat/Makefile     |   1 +
>>  libavformat/allformats.c |   1 +
>>  libavformat/epafdec.c    | 120
>> +++++++++++++++++++++++++++++++++++++++++++++++
>>  4 files changed, 123 insertions(+)
>>  create mode 100644 libavformat/epafdec.c
>>

[...]
>> +    if (!(st->codec->bits_per_coded_sample =
>> av_get_bits_per_sample(st->codec->codec_id))) {
>> +        st->codec->block_align = 32 * st->codec->channels;
>> +        st->codec->bit_rate = st->codec->sample_rate *
>> st->codec->channels * 128 / 5;
>
> the multiplications can overflow

Yes, but that code will not get pushed because I'm not sure
libsndfile implementation is correct for 24 bit files.

Also others bit_rates in other demuxers overflows too ...

>
> [...]
>
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> The greatest way to live with honor in this world is to be what we pretend
> to be. -- Socrates
>