[FFmpeg-devel] [PATCH] ffplay: fix and extend option -codec option

[Marton Balint]

On Sat, 15 Dec 2012, Stefano Sabatini wrote:

> On date Thursday 2012-12-13 11:56:11 +0100, Stefano Sabatini encoded:
>> On date Sunday 2012-12-09 20:03:03 +0100, Marton Balint encoded:
> [...]
>> Sorry, after more thinking I'm not really satisfied with the
>> patch. Indeed being able to set the codec for a generic stream is not
>> consistent with the general framework, which right now only allows to
>> set options for video/audio/subtitle stream.
>>
>> I suggest the following solutions:
>>
>> 1. create the acodec/vcodec/scodec options, as an alias to
>>    codec:{a,v,s}, while keeping support to the old syntax
>>
>> This is consistent with the general options, setting codec:v/a/s gives
>> the wrong impression that ffplay supports the more generic ffmpeg
>> syntax, which is not true, and creating a partial mapping is
>> confusing.
>>
>> 2. allow to specify stream options through the syntax:
>>    -codec:SPECIFIER=OPTIONS
>>
>> This would allow to overcome the limitation at point 1, but would be
>> inconsistent with the ffmpeg syntax.
>>
>> I'll implement 1, while it would be useful to implement 2 at some
>> point, in order to support generic stream option setting (the change
>> could be propagate to the other tools and factorized).
>
> Updated.

LGTM, thanks.

Marton