[FFmpeg-devel] [PATCH] configure: use pkg-config to check for libopenjpeg

[Carl Eugen Hoyos]

Johannes Nixdorf <mixi <at> shadowice.org> writes:

> > > Beginning with version 1.5.1 openjpeg defaults to install its 
> > > headers to /usr/include/openjpeg-${major}.${minor} instead of 
> > > /usr/include making the old test fail.
> > 
> > To the best of my knowledge, this depends on the question 
> > if the packager prefers cmake or make.
> > (That was at least the reason when I last checked.)
> 
> No. They both install the headers to that location

Afair in the past two different locations were 
possible depending on the chosen build system.
(make and cmake installed the headers in different 
locations.)

> and don't provide a compatibility symlink.

Ok (I did not know that my symlinks were added 
by opensuse).

> > Are you sure that there is no symlink from /usr/include/openjpeg 
> > to /usr/include/openjpeg-mjr-min (Opensuse now has two symlinks 
> > to fix the apparent bug in openjpeg-1)?
> 
> This was done by openSUSE and not by the upstream build system (btw., the
> compatibility symlink openSUSE creates is /usr/include/openjpeg.h ->
> /usr/include/openjpeg-1.5/openjpeg.h, not /usr/include/openjpeg/).

> Also I don't see why this would be a bug in openjpeg.

(The bug was that - in the past? - two locations for 
openjpeg.h were possible with the original source package.)

> > Imo, we should check /usr/include/openjpeg.h and 
> > /usr/include/openjpeg/openjpeg.h
> 
> Why? /usr/include/openjpeg/ doesn't exist on any system I know.

$ ll /usr/include/openjpeg
/usr/include/openjpeg -> openjpeg-1.5

Then please check for /usr/include/openjpeg.h and 
/usr/include/openjpeg-1.5/openjpeg.h

> Also this won't work on the unmodified contents of openjpeg packages and
> therefore require the distributors to create that link in their openjpeg
> packages while gaining nothing over the pkg-config approach.

I would expect that the pkg-config approach will brake some 
mingw installations that currently work with openjpeg.

Carl Eugen