[FFmpeg-devel] [PATCH 2/3] Silicon Graphics Motion Video Compressor 1 & 2 decoder

[Paul B Mahol]

On 12/18/12, Peter Ross <pross at xvid.org> wrote:
> On Tue, Dec 18, 2012 at 05:46:30PM +0000, Paul B Mahol wrote:
>> On 12/14/12, Peter Ross <pross at xvid.org> wrote:
>> > Signed-off-by: Peter Ross <pross at xvid.org>
>> > ---
>> >  Changelog               |   1 +
>> >  doc/general.texi        |   2 +
>> >  libavcodec/Makefile     |   2 +
>> >  libavcodec/allcodecs.c  |   2 +
>> >  libavcodec/avcodec.h    |   2 +
>> >  libavcodec/codec_desc.c |  14 +++
>> >  libavcodec/mvcdec.c     | 287
>> > ++++++++++++++++++++++++++++++++++++++++++++++++
>> >  7 files changed, 310 insertions(+)
>> >  create mode 100644 libavcodec/mvcdec.c
>> >
>>
>> [...]
>>
>> > +
>> > +static int decode_mvc1(AVCodecContext *avctx, GetByteContext *gb,
>> > uint8_t
>> > *dst_start, int width, int height, int linesize)
>>
>> This and others functions are still build if one of decoders is disabled.
>> Also i do not see much point in having two different codecs (they do not
>> share
>> much except init and close) in same file.
>
> True. It is extra work then having to roll a custom extradata layout, to
> convey
> both the version and BottumUp flag.

No, I mean file should be split. One for mvc1 and another for mvc2.
>
> The SGI tools libdmedia / dmconvert ''may'' be able to store mvc1 & mvc2 in
> the QuickTime container. I dont have any samples, but will try and generate
> some.
>
> -- Peter
> (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)
>