[FFmpeg-devel] [PATCH] alsdec: channel sorting

[Paul B Mahol]

On 12/21/12, Thilo Borgmann <thilo.borgmann at googlemail.com> wrote:
> Am 21.12.12 15:05, schrieb Paul B Mahol:
>> On 12/21/12, Thilo Borgmann <thilo.borgmann at googlemail.com> wrote:
>>> Am 21.12.12 14:21, schrieb Paul B Mahol:
>>>> Signed-off-by: Paul B Mahol <onemda at gmail.com>
>>>> ---
>>>>  libavcodec/alsdec.c | 13 ++++++++++---
>>>>  1 file changed, 10 insertions(+), 3 deletions(-)
>>>
>>> Probably ok. Have you tested and veryfied using the reference
>>> encoder/decoder?
>>>
>>
>> Yes, without this patch ffmpeg reports CRC error.
>>
>
>> Though instead of aborting i will just ignore channel sorting if invalid
>> values
>> are encountered.
>
> This sounds like a "will do in another patch" ? Currently your patch
> returns
> INVALIDDATA...?
>
>
>> [...]
>> also reference decoder gives broken output for some 6ch files i found on
>> their
>> ftp server.
>
> Please provide me a link to these files segfaulting the reference decoder
> (which
> version do you use btw?)

It is not really file which cause segv.
How to segfault, latest 23 release:
/tmp/mp4alsRM23/bin/{arch}/mp4alsRM23 -m2,1,3,4,7,6 /tmp/out.wav /tmp/out.mp4