[FFmpeg-devel] [PATCH] add code to make ffmpeg.exe can use dxva2 api

[Clément Bœsch]

On Thu, Dec 13, 2012 at 09:40:53AM +0800, Wei Gao wrote:
> From 8703b8e3bf9489b3081885a36014fa761a04522e Mon Sep 17 00:00:00 2001
> From: highgod <highgod0401 at gmail.com>
> Date: Wed, 12 Dec 2012 16:55:36 +0800
> Subject: [PATCH] add code to make ffmpeg.exe can use dxva2 api
> 
> ---
>  cmdutils.c           |    4 +
>  ffmpeg.c             |  194 ++++++++-
>  ffmpeg.h             |    1 +
>  ffmpeg_opt.c         |    6 +-
>  libavcodec/Makefile  |    3 +-
>  libavcodec/avcodec.h |    5 +-
>  libavcodec/pthread.c |  279 ++++++++++++-
>  libavcodec/thread.h  |    6 +
>  libavcodec/utils.c   |   15 +
>  libavcodec/vadxva2.c | 1084
> ++++++++++++++++++++++++++++++++++++++++++++++++++
>  libavcodec/vadxva2.h |  201 ++++++++++
>  11 files changed, 1792 insertions(+), 6 deletions(-)
>  create mode 100644 libavcodec/vadxva2.c
>  create mode 100644 libavcodec/vadxva2.h
> 

Hi,

This patch is pretty hard to review for several reasons. The main ones
are:

 - your mailer mangled the patch (random line breaks in the diff) so we
   can't apply, or even read it easily
 - you are not at all following the coding style of the files you edit
 - almost no indentation (WTF?)

Also, your patch looks like a pretty huge hack inside the ffmpeg tool
instead of working on a generic sane solution.

But basically, until you make the patch readable, it will be hard for us
to even consider integrating it, or even give smart feedbacks about it.

[...]

Regards,

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20121222/bcd5a6c0/attachment.asc>