[FFmpeg-devel] [PATCH 01/10] lavfi: add avfilter_get_audio_buffer_ref_from_arrays_nolayout.

[Stefano Sabatini]

On date Sunday 2012-12-30 19:57:45 +0100, Nicolas George encoded:
> Le decadi 10 nivôse, an CCXXI, Stefano Sabatini a écrit :
> > _arrays2() should be fine as well (and shorter), and "nolayout" is
> > confusing (since layout *can* be specified).
> 
> I agree that nolayout is confusing, but if I go with _arrays2, there is a
> big risk that someone (A.... K......?) will add a function with the same
> name but a different semantic, and then we have big problems.

What about 
avfilter_get_audio_buffer_ref_from_arrays_channels
?

mnemonic: the new function supports a new "channels" parameter.

> The function can not be made private either, because creating a buffer is
> necessary to insert frames in lavfi with certain APIs.

> 
> > spurious
> 
> Locally fixed.
> 
> > av_log ERROR?
> 

> It is inside a deprecated and unused function, I would not bother with it,
> unless you think it is really necessary.

I don't in that case.

[...]
-- 
FFmpeg = Friendly and Fiendish Meaningful Ponderous Excellent Gladiator