[FFmpeg-devel] [PATCH 4/4] lavfi/subtitles: set a different description between ass and subtitles.

[Clément Bœsch]

On Mon, Dec 31, 2012 at 11:34:21AM +0100, Stefano Sabatini wrote:
> On date Monday 2012-12-31 11:19:44 +0100, Clément Bœsch encoded:
> > ---
> >  libavfilter/vf_subtitles.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/libavfilter/vf_subtitles.c b/libavfilter/vf_subtitles.c
> > index d704ebb..46662bc 100644
> > --- a/libavfilter/vf_subtitles.c
> > +++ b/libavfilter/vf_subtitles.c
> > @@ -239,7 +239,7 @@ static av_cold int init_ass(AVFilterContext *ctx, const char *args)
> >  
> >  AVFilter avfilter_vf_ass = {
> >      .name          = "ass",
> > -    .description   = NULL_IF_CONFIG_SMALL("Render subtitles onto input video using the libass library."),
> > +    .description   = NULL_IF_CONFIG_SMALL("Render ASS subtitles onto input video using the libass library."),
> >      .priv_size     = sizeof(AssContext),
> >      .init          = init_ass,
> >      .uninit        = uninit,
> > @@ -352,7 +352,7 @@ end:
> >  
> >  AVFilter avfilter_vf_subtitles = {
> >      .name          = "subtitles",
> > -    .description   = NULL_IF_CONFIG_SMALL("Render subtitles onto input video using the libass library."),
> > +    .description   = NULL_IF_CONFIG_SMALL("Render text subtitles onto input video using the libass library."),
> 
> "text subtitles" is something like "video images" or "audio sound",
> "Render subtitles ..." should be fine.
> 

bitmap subtitles like VobSub are common, and they are not supported by the
filter, that's the reason I insisted on this.

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20121231/ea55aeef/attachment.asc>