[FFmpeg-devel] [PATCH] vf_fspp: use LOCAL_MANGLE instead of MANGLE.

[Reimar Döffinger]

On Wed, Feb 08, 2012 at 11:22:01PM +0100, Clément Bœsch wrote:
> On Wed, Feb 08, 2012 at 07:48:51PM +0100, Clément Bœsch wrote:
> > On Tue, Feb 07, 2012 at 07:18:09PM +0100, Clément Bœsch wrote:
> > > On Mon, Feb 06, 2012 at 07:23:40PM +0100, Clément Bœsch wrote:
> > > > The symbols are locals, thus the EXTERN_PREFIX should be omitted. This
> > > > might fix the llvm-gcc fate instance.
> > > > ---
> > > > I hope I'm not wrong here, but using MANGLE here doesn't sound right to me and
> > > > it still works here locally. Also, I can not test on a Darwin machine, so any
> > > > Mac user is welcome to test.
> > > > ---
> > > >  libavfilter/libmpcodecs/vf_fspp.c |   80 ++++++++++++++++++-------------------
> > > >  1 files changed, 39 insertions(+), 41 deletions(-)
> > > > 
> > > > diff --git a/libavfilter/libmpcodecs/vf_fspp.c b/libavfilter/libmpcodecs/vf_fspp.c
> > > [...]
> > > 
> > > I will commit this in a day or two if I see no comment, and will revert
> > > ASAP if fate goes red.
> > > 
> > 
> > Pushed. Wait & see.
> > 
> 
> Reverted. Any suggestion on why this does fail is welcome.

LOCAL_MANGLE is for symbols also declared inside __asm__, not "local" as
in the same file.
I'd suspect that that compiler version just completely optimizes those
variables away, so you have to use the same hack as for Intel of
removing the "static" (though that might just cause symbol collisions
instead, not sure).