[FFmpeg-devel] [patch] glob matching for image series

[Nicolas George]

L'octidi 18 nivôse, an CCXX, Brian Olson a écrit :
> I posted copy of my repo to:
> http://bolson.org/~bolson/ffmpeg.git/
> 
> My changes are in a branch "bolson-wordexp" (slightly misnamed...)
> 
> I can make a patch file if you have a preferred way of dealing with git.

The preferred way for external contributors (and most internal ones too, in
fact) is to use git send-email, or the equivalent using git format-patch.
You will probably need to squash your patches together into a single one.
The patch then gets reviewed inline.

> I tried to do this a year ago but used the "wordexp" library, but was
> blocked because wordexp can run shell commands passed in as an argument,
> creating a potential security hole if someone managed to make a web page
> pass arguments all the way in to "-i ...*.jpg" of ffmpeg. I backed off to
> the lesser "glob" library that just does pattern matching on file names.
> 
> My change includes an update to the configure script, a documentation
> change, and the functional change to the code that reads image sequences.

That sounds quite thorough, I hope we can make it work.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120108/ee4ef46f/attachment.asc>