[FFmpeg-devel] [PATCH 1/2] libmp3lame: It appears the buffer used is a bit too small.

[Michael Niedermayer]

On Mon, Jan 09, 2012 at 12:29:52AM +0100, Alexander Strasser wrote:
> Hi,
> 
> Michael Niedermayer wrote:
> > On Sun, Jan 08, 2012 at 08:30:26PM +0000, Paul B Mahol wrote:
> > > On 1/8/12, Michael Niedermayer <michaelni at gmx.at> wrote:
> > > > On Sun, Jan 08, 2012 at 07:46:56PM +0000, Paul B Mahol wrote:
> > > >> On 1/8/12, Michael Niedermayer <michaelni at gmx.at> wrote:
> > > >> > Increase it by an arbitrary amount.
> > > >> > Fixes part of Ticket676
> > > >> >
> > > >> > Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> > > >> > ---
> > > >> >  libavcodec/libmp3lame.c |    2 +-
> > > >> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > > >> >
> > > >>
> > > >> Add AVOption with sensible limitations and default value?
> > > >
> > > > the value should be made large enough to work in all cases,
> > > > apparently the value that was there was too small or theres a bug
> > > > elsewhere. I dont think making it user selectable is going to help
> > > 
> > > Yes, I agree.
> > 
> > so, ok if we apply this and see if it is large enough ?
> > or is there some volunteer to investigate this further ?
> 
>   Unfortunately I am not volunteering to investigate, but please if
> you apply the patch increasing the buffer size also add a comment.
> 
>   Quick suggestion:
>   FIXME: Buffer size to small? Adding 1000 to make up for it.

locally fixed

ill apply this tomorrow unless i hear objections

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many that live deserve death. And some that die deserve life. Can you give
it to them? Then do not be too eager to deal out death in judgement. For
even the very wise cannot see all ends. -- Gandalf
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120109/2798ce11/attachment.asc>