[FFmpeg-devel] [PATCH] sws: Move yuv2rgb cliping into the tables.

[Alexander Strasser]

Hi Micheal!

Michael Niedermayer wrote:
> On Tue, Jan 10, 2012 at 09:19:50PM +0100, Michael Niedermayer wrote:
> > On Tue, Jan 10, 2012 at 09:02:03PM +0100, Reimar Döffinger wrote:
> > > On Tue, Jan 10, 2012 at 08:57:29PM +0100, Michael Niedermayer wrote:
> > > > Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> > > > ---
> > > >  libswscale/swscale.c          |   31 +++++++++++++++----------------
> > > >  libswscale/swscale_internal.h |   10 ++++++----
> > > >  libswscale/yuv2rgb.c          |   22 ++++++++++------------
> > > >  3 files changed, 31 insertions(+), 32 deletions(-)
> > > 
> > > Looks good to me.
> > > I'm not that convinced if/how much faster it will be on CPUs with small
> > > caches, it doubles the size of the tables after all.
> > 
> > yep but accesses should be quite localized, color does not change so
> > radically from one pixel to the next normally and the areas used for
> > cliping should rarely be accessed
> > 
> > ill wait a bit more to give others also a chance to review if anyone
> > wants
> 
> also, without this patch there are functions in there that are missing
> neccesary cliping

  Just a quick note in case this will be committed: The positive variant of
that comment would be a good fit for the commit message.

  Alexander