[FFmpeg-devel] [PATCH] doc: document amerge filter as an alternative for the -map_channel limitation.

[Tim Nicholson]

Hi Clément



Clément Bœsch <ubitux at gmail.com> wrote:-

> On Tue, Jan 10, 2012 at 03:45:18PM +0000, Tim Nicholson wrote:
> 
> Hi Tim,
> 
>>  ----- Original Message -----
>>  > From: Clément Bœsch <ubitux at gmail.com>
>>  > To: ffmpeg-devel at ffmpeg.org
>>  > Cc: Clément Bœsch <clement.boesch at smartjog.com>
>>  > Sent: Tuesday, 10 January 2012, 10:52
>>  > Subject: [FFmpeg-devel] [PATCH] doc: document amerge filter as an 
> alternative for the -map_channel limitation.
>>  > 
>>  > From: Clément Bœsch <clement.boesch at smartjog.com>
>>  > 
>>  > ---
>>  > doc/ffmpeg.texi |   19 +++++++++++++++++++
>>  > 1 files changed, 19 insertions(+), 0 deletions(-)
>>  > 
>>  > diff --git a/doc/ffmpeg.texi b/doc/ffmpeg.texi
>>  > index 83a45a8..f4df331 100644
>>  > --- a/doc/ffmpeg.texi
>>  > +++ b/doc/ffmpeg.texi
>>  > @@ -833,6 +833,25 @@ possible, for example, to turn two separate mono 
> streams 
>>  > into a single stereo
>>  > stream. However spliting a stereo stream into two single channel mono 
> streams
>>  > is possible.
>>  > 
>>  > +If you need this feature, a possible workaround is to use the 
> @emph{amerge}
>>  > +filter. For example, if you need to merge a media (here 
> @file{input.mkv}) with
>>  > +6 mono audio streams into one single 5.1 channel audio stream:
>> 
>>  Would it not be better initially to give an example of the previous example 
> (sic), e.g turning dual mono into stereo?
> 
> As you wish, changed.
> 
>>  And preferably from a file also containing video so it is clear how to use 
> it instead of the "map_channel", then it
>>  looks like a workaround for the case in point.
>> 
> 
> OK.
> 

I think that's much better, and is in keeping with that section.

>>  I think that more comprehensive samples (with the complete command line as 
> you do) could then go in the actual amerge
>>  section which is somewhat terse and lacking enough examples to make the 
> syntax clear for all cases.
> 
> I moved the current example to the amerge section.
> 

Its good to have that as both a 5.1 example, and single source file as
the other example does not explain the stream syntax well.

> Note that this will likely be changed "soon" again because of the
> incoming remapchannel filter.
> 

For sure, and then I think a comprehensive set of examples will be in order....

> -- 
> Clément B.



Overall LGTM
 
-- 
Tim