[FFmpeg-devel] [PATCH] V4L2 compliance: Make sure VIDIOC_S_INPUT is called before querying/setting any input properties

[Luca Abeni]

On 01/12/2012 03:42 PM, Rupert Eibauer wrote:
[...]
>>> the attachment is ok wraping wise, luca, please review if you have
> time
>> At a first glance, it looks ok... But I am pretty sure that the code
> worked
>> fine last time I used it (1 year ago, I think).
>> So, I need to check what happened, and why this change is needed now (or
>> maybe I am simply misremembering something... :).
>
> The problem will not be visible on single-input devices. In fact, you will
> only see
> it when you have a device with multiple inputs and the inputs differ in
> the set of allowed parameters for VIDIOC_S_FMT.
Yes, I agree. And I think the patch is ok (I assume you tested it :).
BTW, which kind of v4l card has different video resolutions for the different
inputs (just curious)?



			Thanks,
				Luca