[FFmpeg-devel] [PATCH]libopenjpeg 64bit encoding

[Carl Eugen Hoyos]

Michael Bradshaw <mbradshaw <at> sorensonmedia.com> writes:

> @@ -219,7 +224,7 @@ static int libopenjpeg_copy_rgb16(AVCodecContext
> *avctx, AVFrame *frame, opj_ima
> 
> Just a thought: libopenjpeg_copy_rgb16 should probably be renamed to
> libopenjpeg_copy_rgba16.

?
It is used for RGB48 which has no "a" channel.

>  Also, would you be opposed to renamin> libopenjpeg_copy_rgba to
> libopenjpeg_copy_rgba8, seeing as we now have two versions of the function and
> it'll clarify which one it is?

I wanted to suggest to rename it to libopenjpeg_copy_rgb8() although it is also
used for GRAY8 - do you have a better suggestion?

(Does jasper recognize GRAY16?)

Do you think the patch is useful overall?
It would currently allow reencoding tif -> j2k on le, dpx/sgi -> j2k on be,
colour transformations will probably be supported in the future.

Carl Eugen