[FFmpeg-devel] [PATCH] Fix ff_get_guid for short reads or errors.

[Michael Niedermayer]

On Sun, Jan 15, 2012 at 08:39:25PM +0100, Reimar Döffinger wrote:
> On Sun, Jan 15, 2012 at 08:19:16PM +0100, Michael Niedermayer wrote:
> > On Sun, Jan 15, 2012 at 05:00:29PM +0100, Reimar Döffinger wrote:
> > > Current code would just return uninitialized data with no way
> > > to detect this condition.
> > > Instead, fill the whole GUID with 0 in that case.
> > > Fixes valgrind uninitialized data errors in fate-seek-lavf_asf.
> > > 
> > > Signed-off-by: Reimar Döffinger <Reimar.Doeffinger at gmx.de>
> > 
> > LGTM, thx
> 
> Actually not quite, I forgot that sizeof is unsigned, so it would
> not work for straight-out read errors.
> Pushed with a fix for that.
> Hm, I just realized I could have used != instead of casting to int,
> would that have been preferred?

iam happy with either

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Complexity theory is the science of finding the exact solution to an
approximation. Benchmarking OTOH is finding an approximation of the exact
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120115/d5aa2ae4/attachment.asc>