[FFmpeg-devel] [PATCH] lavfi: use libswr in af_aresample.

[Clément Bœsch]

On Sat, Jan 21, 2012 at 11:57:25PM +0100, Michael Niedermayer wrote:
> On Sat, Jan 21, 2012 at 09:10:39PM +0100, Clément Bœsch wrote:
> > ---
> > Question: is there any need of flushing? (is the number of output samples exact
> > enough?)
> > ---
> >  configure                  |    1 +
> >  libavfilter/af_aresample.c |  272 ++++----------------------------------------
> >  2 files changed, 23 insertions(+), 250 deletions(-)
> 
> LGTM if tested, flushing is buggy but it was already before ...
> 

Trying various resampling, the output sounds correct to me. However, it
differs from the previous version of the filter...

Also I noted a pretty strange issue with the following command:

  ffmpeg -f lavfi -i amovie=a.mp3,aresample=8000 -t 10 out.wav

Before the patch: 0 seconds output (a few bytes)
After  the patch: -t 10 is ignored, the whole song is resampled

Any idea what's going on?

I have no idea what could have gone wrong, but I'd like to think the
changes I did didn't get things worse, so I'll push this anyway in the
next days if there is no objection.

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120124/32f7b897/attachment.asc>