[FFmpeg-devel] [PATCH][WIP] lavfi/aconvert: use libswresample.

[Nicolas George]

Le septidi 7 pluviôse, an CCXX, Clément Bœsch a écrit :
> BTW, what is planned for the audio packing in lavfi?

I think I do not understand what you mean here.

> @@ -163,6 +82,9 @@ static int query_formats(AVFilterContext *ctx)
>      avfilter_formats_ref(avfilter_make_all_formats(AVMEDIA_TYPE_AUDIO),
>                           &inlink->out_formats);
>      if (aconvert->out_sample_fmt != AV_SAMPLE_FMT_NONE) {
> +        if (aconvert->out_packing_fmt != -1)
> +            aconvert->out_sample_fmt = av_get_alt_sample_fmt(aconvert->out_sample_fmt,
> +                                                             aconvert->out_packing_fmt);

I think there is something fishy I do not understand going on here. Correct
me if I am wrong: libavfilter has both the AVFilterLink.planar bit and the
information in the sample format (FOO42 of FOO42P), and filters that
actually handle planar samples have to play along and hide that fact from
the user.

>      av_get_channel_layout_string(buf1, sizeof(buf1),
>                                   -1, inlink ->channel_layout);
>      av_get_channel_layout_string(buf2, sizeof(buf2),
>                                   -1, outlink->channel_layout);

Nit: in_layout_name_in and out_layout_name, maybe? But I realize after
having written that that this is not part of the patch, this was the
original code. Disregard this comment.


I did not see any obvious flaw, but do not take it for a proper review.

Thanks for the work, still.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120126/4f0638b2/attachment.asc>