[FFmpeg-devel] [PATCH] lavu: introduce av_parse_ratio() and use it in ffmpeg and lavfi/aspect

[Stefano Sabatini]

On date Wednesday 2012-01-25 20:35:32 +0100, Stefano Sabatini encoded:
> On date Wednesday 2012-01-25 19:31:36 +0100, Reimar Döffinger encoded:
> > On Tue, Jan 24, 2012 at 11:46:57PM +0100, Stefano Sabatini wrote:
> > > On date Saturday 2012-01-21 15:24:23 +0100, Reimar Döffinger encoded:
> > > > On Sat, Jan 21, 2012 at 02:59:59PM +0100, Stefano Sabatini wrote:
> > > > > av_parse_ratio_l(AVRational *q, const char *str, int max, void *log_ctx, int log_level_off)
> > > > 
> > > > As long as you write out "log". Saving 2 characters is hardly worth the
> > > > obfuscation.
> > > 
> > > The problem is that then it sounds "av_parse_ratio_log()" which reads
> > > as "parse the ratio log" why "_l" just denotes a variant of the
> > > function (like _e, _d, _s, used in other APIs).
> > 
> > Well, I'd say and just as much only acting as confusion instead of real
> > help :-)
> > I mean it is getting a bit long, but what about _logged?
> 
> > Or maybe giving the define instead the name av_parse_ratio_quiet?
> 
> Works for me, especially considering that the logging variant is "the
> real thing" and the other is just an humble macro.
> 
> > None of those sound good enough to me that I'd be mad at you for
> > not changing it, but I'd really prefer something better than
> > a single letter that could really mean anything.
> 
> I'll let other people bikes^H^H^H^H^H propose their favorite names,
> then I'll update the patch in a few days if I read no more proposals.

Upped, please review, I'll commit in a few days/a week if I read no
comments.
-- 
FFmpeg = Forgiving and Fanciful Mortal Proud EnGraver
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-lavu-introduce-av_parse_ratio-and-use-it-in-ffmpeg-a.patch
Type: text/x-diff
Size: 7437 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120127/405e2957/attachment.bin>