[FFmpeg-devel] [RFC] lavu PTS printing utils

[Stefano Sabatini]

On date Saturday 2012-01-28 12:14:08 +0100, Stefano Sabatini encoded:
> On date Friday 2012-01-27 19:09:38 +0100, Clément Bœsch encoded:
> > On Fri, Jan 27, 2012 at 01:35:06PM +0100, Stefano Sabatini wrote:
> [...]
> > > * double precision is reduced to 6 digits, which looks enough for A/V
> > >   applications, could not be enough for scientific computing but again
> > >   given the application domain I don't think this is a much serious
> > >   issue
> > > 
> > 
> > Isn't the way of printing a floating value up to a certain precision
> > depending on the printf implementation anyway?
> 
> Yes, but the %g representation should guarantee that the maximum size
> is limited to a well defined size.
> 
> > > * "ts" is favored over "timestamp" for brevity/convenience reasons
> > > 
> > > * "ts2str" naming is kept in the macro for brevity/convenience reasons
> > > 
> > 
> > I'm OK with this.
> > 
> > [...]
> > > From f7ba7daa66ed3cb79ab425d0494889be8ad685f7 Mon Sep 17 00:00:00 2001
> > > From: Stefano Sabatini <stefasab at gmail.com>
> > > Date: Fri, 20 Jan 2012 17:06:26 +0100
> > > Subject: [PATCH] ffmpeg.c: use timestamp.h utilities
> > > 
> > > ---
> > >  ffmpeg.c |   33 ++++++++++++++++++++++++++-------
> > >  1 files changed, 26 insertions(+), 7 deletions(-)
> > > 
> > > diff --git a/ffmpeg.c b/ffmpeg.c
> > > index 88a4761..1243df6 100644
> > > --- a/ffmpeg.c
> > > +++ b/ffmpeg.c
> > > @@ -23,6 +23,8 @@
> > >   * multimedia converter based on the FFmpeg libraries
> > >   */
> > >  
> > > +#define DEBUG_TS
> > > +
> > 
> 
> > I'm not really fond of this; why not use the -debug pts (see FF_DEBUG_PTS)
> > or a new -debug ts instead?
> 
> This is just a quick hack for showing how to use how to use the new
> utils, we can add an ffmpeg -debug ts option for that.
> -- 
> FFmpeg = Fierce and Faithless Monstrous Puristic Elastic Gigant

> From af61c764221783a4bd603385d5f29f589cb898b5 Mon Sep 17 00:00:00 2001
> From: Stefano Sabatini <stefasab at gmail.com>
> Date: Tue, 17 Jan 2012 17:12:42 +0100
> Subject: [PATCH] lavu: add timestamp.h header with convenience timestamp
>  utilities

I'd like to push this in a few days, ping (Michael)?
-- 
FFmpeg = Fancy & Freak Muttering Portable Exuberant Gorilla