[FFmpeg-devel] [PATCH] movtextdec: MPEG4 Part 17 Timed Text Decoder.

Philip Langdale philipl at overt.org
Sun Jul 1 19:12:17 CEST 2012


On 30.06.2012 11:19, Reimar Döffinger wrote:
> On Sat, Jun 23, 2012 at 02:17:49PM -0700, Philip Langdale wrote:
>> +            if (!line_start && *(text + 1) != ' ' &&
>> +                *(text + 1) != '\r' && *(text + 1) != '\r')
>
> IMHO text[1] is far more readable syntax than *(text + 1)
> Also you could make it discard trailing spaces while at it by also
> checking for !text[1] or not?

I'll change that. It already tries to discard trailing whitespace - 
that's
what the check against \r and \n is for at the end.

--phil


More information about the ffmpeg-devel mailing list