[FFmpeg-devel] [PATCH 1/5] libavutil: prefix all log messages with thread id

[Nicolas George]

Le sextidi 16 messidor, an CCXX, Martin Carroll a écrit :
> Will do.

Thanks.

> Oops, my goof.  My reasoning was that the code that you refer to is
> called from the thread *creator*, not the threads themselves, but of
> course anyone, including multiple threads, can be thread creators.
> I will fix.

Even if the structure was modified only from the "main" thread, it is
accessed from a lot of threads. With SMP systems, synchronization is
necessary.

> I default to not using thread-local storage because thread-local storage
> used to be nonportable, and I have no idea how many archaic machines
> ffmpeg is being built on.  However, if thread-local storage is preferred
> by ffmpeg folks, I will convert to that.  Just let me know.

IMHO, for new features, especially non-essential ones, it is better to use
the most modern / suited API, and let users of platforms where these API are
not available find a solution.

But this is only my personal opinion, I am not speaking for all the
developers.

Thanks for your work.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120703/59b1d4df/attachment.asc>