[FFmpeg-devel] [PATCH 1/3] oggdec: add support for Opus codec.

[Alexander Strasser]

Hi Nicolas,

  looks good to me, but please note I do not have any special knowledge
about Opus in Ogg.

  Also if you want to read a little rant look below, otherwise please
skip the remainder of this mail :)

Nicolas George wrote:
> This patch also introduces CODEC_ID_OPUS.
> 
> Signed-off-by: Nicolas George <nicolas.george at normalesup.org>
> ---
>  libavcodec/avcodec.h       |    1 +
>  libavformat/Makefile       |    1 +
>  libavformat/oggdec.c       |    1 +
>  libavformat/oggdec.h       |    1 +
>  libavformat/oggparseopus.c |  120 ++++++++++++++++++++++++++++++++++++++++++++
>  5 files changed, 124 insertions(+)
>  create mode 100644 libavformat/oggparseopus.c
[...]
> diff --git a/libavformat/Makefile b/libavformat/Makefile
> index 9eaf28a..69eec0c 100644
> --- a/libavformat/Makefile
> +++ b/libavformat/Makefile
> @@ -200,6 +200,7 @@ OBJS-$(CONFIG_OGG_DEMUXER)               += oggdec.o         \
>                                              oggparsedirac.o  \
>                                              oggparseflac.o   \
>                                              oggparseogm.o    \
> +                                            oggparseopus.o   \

  hasnothingtodowiththispatchbutthatisthemosthorriblenamingschemeicanimagineEvenCamelCaseWouldHaveDoneBetterThough_i_hate_that_in_file_names

>                                              oggparseskeleton.o \
>                                              oggparsespeex.o  \
>                                              oggparsetheora.o \
[...]

  Alexander