[FFmpeg-devel] [PATCH] lavf/segment: add -segment_delta option

[Michael Niedermayer]

On Wed, Jul 04, 2012 at 01:50:55AM +0200, Stefano Sabatini wrote:
> On date Wednesday 2012-07-04 01:22:05 +0200, Stefano Sabatini encoded:
> > FIXME: bump micro version
> > ---
> >  doc/muxers.texi       |   11 +++++++++++
> >  libavformat/segment.c |   13 +++++++++++++
> >  2 files changed, 24 insertions(+), 0 deletions(-)
> 
> Doh, that was incomplete due to a rebasing issue, updated.
> -- 
> FFmpeg = Formidable & Faithless Mystic Political Elastic God

>  doc/muxers.texi       |   11 +++++++++++
>  libavformat/segment.c |   15 +++++++++++++--
>  2 files changed, 24 insertions(+), 2 deletions(-)
> c8f084204ed40504adba819c1ae929c3938d6ce3  0004-lavf-segment-add-segment_delta-option.patch
> From 6020215beba95c0554d8f110daaf767b2a88cb50 Mon Sep 17 00:00:00 2001
> From: Stefano Sabatini <stefasab at gmail.com>
> Date: Sat, 28 Jan 2012 22:21:43 +0100
> Subject: [PATCH] lavf/segment: add -segment_delta option
> 
> FIXME: bump micro version
> ---
>  doc/muxers.texi       |   11 +++++++++++
>  libavformat/segment.c |   15 +++++++++++++--
>  2 files changed, 24 insertions(+), 2 deletions(-)
> 
> diff --git a/doc/muxers.texi b/doc/muxers.texi
> index c63356a..9e1bf75 100644
> --- a/doc/muxers.texi
> +++ b/doc/muxers.texi
> @@ -452,6 +452,17 @@ segment start and end time expressed in seconds.
>  The segment muxer supports the following options:
>  
>  @table @option
> + at item segment_delta @var{delta}
> +Specify the accuracy in seconds when selecting the start time for a
> +segment. Default value is "0".
> +
> +This is especially useful with video segments, which are split at GOP
> +boundaries. When delta is specified a given key-frame is selected if
> +its PTS satisfies the relation:
> + at example
> +PTS >= start_time - delta
> + at end example

this description is hard to understand, otherwise patch LGTM

Maybe it would be clearer if the problem segment_delta solves would
be described, or maybe the effect of a larger or small delta could
be described


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The real ebay dictionary, page 2
"100% positive feedback" - "All either got their money back or didnt complain"
"Best seller ever, very honest" - "Seller refunded buyer after failed scam"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120707/be159765/attachment.asc>