[FFmpeg-devel] [PATCH 3/3] lavf/mxfenc: fix dnxhd codec uls

[Michael Niedermayer]

On Tue, Jul 10, 2012 at 04:43:07PM +0200, Matthieu Bouron wrote:
> On Tue, Jul 10, 2012 at 01:34:15PM +0200, Tomas Härdin wrote:
> > On Mon, 2012-07-09 at 20:01 +0200, Matthieu Bouron wrote:
> > > ---
> > > Hi,
> > > 
> > > This commit fixes the wrong codec uls i introduced with the support of the
> > > dnxhd codec.
> > > For reference: RP224 http://www.smpte-ra.org/mdd/index.html
> > 
> > They're not actually wrong per se - you just used version = 1 instead of
> > version = 10. All decent MXF readers ignore the version byte.
> > 
> 
> I encountered a tool which checks the version number.
> 
> > Anyway, the patch looks OK. Using version 10 is of course prettier,
> > since v10 is the latest RP224.
> > 
> > You could probably squash all three of these into a single patch, or at
> > least this and the first one since they both deal with codec UL stuff.
> >
> 
> Sounds like a good idea to squash all the three commits into one single
> patch. Thanks for the review.
> 
> I also noticed that patch 2/3 is wrong since it force 16:9 aspect ratio
> for the dv codec and not the dnxhd codec :(
> 
> New (single) patch attached.

patch applied

thanks

also thanks to Tomas for the review

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is dangerous to be right in matters on which the established authorities
are wrong. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120711/f2e5624f/attachment.asc>