[FFmpeg-devel] [PATCH] lavc: add metadata to AVFrame

[Michael Niedermayer]

On Thu, Jul 12, 2012 at 01:40:19AM +0200, Stefano Sabatini wrote:
> On date Wednesday 2012-07-11 13:36:50 +0200, Michael Niedermayer encoded:
> > On Wed, Jul 11, 2012 at 01:21:51PM +0200, Stefano Sabatini wrote:
> > > From: Thomas Kühnel <kuehnelth at googlemail.com>
> > > 
> > > See thread:
> > > Subject: [libav-devel] [PATCH 1/3] avcodec: add metadata to AVFrame
> > > Date: Tue,  4 Oct 2011 00:19:51 +0200
> > > 
> > > FIXME: add APIchanges entry and bump minor
> > > ---
> > >  libavcodec/avcodec.h |    7 +++++++
> > >  1 files changed, 7 insertions(+), 0 deletions(-)
> > > 
> > > diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
> > > index c850963..c395784 100644
> > > --- a/libavcodec/avcodec.h
> > > +++ b/libavcodec/avcodec.h
> > > @@ -1311,6 +1311,13 @@ typedef struct AVFrame {
> > >       * - decoding: Read by user.
> > >       */
> > >      int64_t pkt_duration;
> > > +
> > > +    /**
> > > +     * Metadata.
> > > +     * - encoding: Set by user.
> > > +     * - decoding: Set by libavcodec.
> > > +     */
> > > +    AVDictionary *metadata;
> > 
> > a accessor should be added so this can be accessed from outside
> > libavcodec in a AVFrame ABI independant way
> 
> Updated.
> -- 
> FFmpeg = Fundamentalist and Frenzy Minimal Pacific Evangelical Guide

>  avcodec.h |    9 +++++++++
>  1 file changed, 9 insertions(+)
> 3b99e137cb9dad1bd70ab687caa30eaeba8e9d69  0001-lavc-add-metadata-to-AVFrame.patch
> From 570a40161520b566a40304377e6ae374e69351d2 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Thomas=20K=C3=BChnel?= <kuehnelth at googlemail.com>
> Date: Mon, 26 Sep 2011 22:26:13 +0200
> Subject: [PATCH] lavc: add metadata to AVFrame
> 
> See thread:
> Subject: [libav-devel] [PATCH 1/3] avcodec: add metadata to AVFrame
> Date: Tue,  4 Oct 2011 00:19:51 +0200
> 
> FIXME: add APIchanges entry and bump minor
> ---
>  libavcodec/avcodec.h |    9 +++++++++
>  1 files changed, 9 insertions(+), 0 deletions(-)
> 
> diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
> index c850963..424e49c 100644
> --- a/libavcodec/avcodec.h
> +++ b/libavcodec/avcodec.h
> @@ -1311,6 +1311,13 @@ typedef struct AVFrame {
>       * - decoding: Read by user.
>       */
>      int64_t pkt_duration;
> +
> +    /**
> +     * Metadata.
> +     * - encoding: Set by user.
> +     * - decoding: Set by libavcodec.
> +     */

missing note that the field should only be accessed through the
accessors from outside libavcodec due to ABI

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

What does censorship reveal? It reveals fear. -- Julian Assange
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120713/962d6f0b/attachment.asc>