[FFmpeg-devel] [PATCH] libx264: list possible presets and tunes.

[Michael Niedermayer]

On Sat, Jul 14, 2012 at 12:38:15AM +0200, Nicolas George wrote:
[...]
> @@ -287,7 +287,16 @@ static av_cold int X264_init(AVCodecContext *avctx)
>      x4->params.analyse.i_chroma_qp_offset = avctx->chromaoffset;
>      if (x4->preset || x4->tune)
>          if (x264_param_default_preset(&x4->params, x4->preset, x4->tune) < 0) {
> +            int i;
>              av_log(avctx, AV_LOG_ERROR, "Error setting preset/tune %s/%s.\n", x4->preset, x4->tune);
> +            av_log(avctx, AV_LOG_INFO, "Possible presets:");
> +            for (i = 0; x264_preset_names[i]; i++)
> +                av_log(avctx, AV_LOG_INFO, " %s", x264_preset_names[i]);
> +            av_log(avctx, AV_LOG_INFO, "\n");
> +            av_log(avctx, AV_LOG_INFO, "Possible tunes:");
> +            for (i = 0; x264_tune_names[i]; i++)
> +                av_log(avctx, AV_LOG_INFO, " %s", x264_tune_names[i]);
> +            av_log(avctx, AV_LOG_INFO, "\n");
>              return AVERROR(EINVAL);
>          }

in absence of other comments, LGTM

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Let us carefully observe those good qualities wherein our enemies excel us
and endeavor to excel them, by avoiding what is faulty, and imitating what
is excellent in them. -- Plutarch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120714/e04a1d7e/attachment.asc>